This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: dht.findPeer API endpoint returns ndjson #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
approved these changes
Apr 6, 2020
jacobheun
reviewed
Apr 9, 2020
| @@ -9,23 +9,23 @@ module.exports = configure(api => { | |||
| return async function findPeer (peerId, options = {}) { | |||
| options.arg = `${Buffer.isBuffer(peerId) ? new CID(peerId) : peerId}` | |||
|
|
|||
| const res = await api.post('dht/findpeer', { | |||
| const res = await api.ndjson('dht/findpeer', { | |||
There was a problem hiding this comment.
Since this was changed from a .post it needs to include method: 'POST' in the options.
See https://github.com/ipfs/js-ipfs/blob/master/packages/ipfs-http-client/src/dht/find-provs.js#L10-L15
There was a problem hiding this comment.
Good point - I think @lidel was going to PR the client to change all methods to post.
There was a problem hiding this comment.
I can do that now though..
There was a problem hiding this comment.
Taking shape here: #2977
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't appear to be documented, but
POST /api/v0/dht/findpeercan return multiple results, so treat it asndjson.Otherwise we see these sorts of test failures: