-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipfs-test-lib: add shellquote() #1757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function can be usefull in many places. See for example: #1742 Git has `git rev-parse --sq-quote` that does the same thing. License: MIT Signed-off-by: Christian Couder <[email protected]>
jbenet
added a commit
that referenced
this pull request
Sep 27, 2015
ipfs-test-lib: add shellquote()
In hindsight, it might actually be nicer to do this instead:
|
In fact, my original implementation is just plain wrong, the above should work correctly. Sorry for that. Here’s a test script:
|
@ion1 @chriscool maybe let's add a test |
Here’s something that could be used as a basis for a unit test.
|
Ok, I will add some tests. Thanks @ion1! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function can be usefull in many places.
See for example:
#1742
Git has
git rev-parse --sq-quote
that does the same thing.License: MIT
Signed-off-by: Christian Couder [email protected]