Code

Refactoring Commands#196

Code

Closed

mappum wants to merge 142 commits intomasteripfs/kubo:masterfrom commands-refactoripfs/kubo:commands-refactorCopy head branch name to clipboard

+1,665-74

Commits

Commits on Oct 31, 2014

• move ipfs commands

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  4a75297

  Copy full SHA for 4a75297

• copy to old location

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  49f5b7b

  Copy full SHA for 49f5b7b

• move daemon temporarily

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  8b695f6

  Copy full SHA for 8b695f6

• add a copy of daemon to be edited when creating new commands

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  3fd7cec

  Copy full SHA for 3fd7cec

• core/commands: Added root command (with test subcommands)

  mappum

  committed
  f9030e7

  Copy full SHA for f9030e7

• server/http: Added HTTP API handler

  mappum

  committed
  e687d58

  Copy full SHA for e687d58

• commands: Made Response#Error return an *Error instead of an error

  mappum

  committed
  6379859

  Copy full SHA for 6379859

• server/http: Don't cast res.Error() to an Error (fixes panix on response errors)

  mappum

  committed
  3049d51

  Copy full SHA for 3049d51

• core/commands: Added more advanced test subcommand

  mappum

  committed
  76def57

  Copy full SHA for 76def57

• commands: Removed unused output stream field from Response

  mappum

  committed
  43f8629

  Copy full SHA for 43f8629

• server/http: Fixed error when using long encoding option name

  mappum

  committed
  22774cb

  Copy full SHA for 22774cb

• commands: Made Response implement io.Reader

  mappum

  committed
  15a2329

  Copy full SHA for 15a2329

• server/http: Use Response as Reader instead of manually getting output data

  mappum

  committed
  b0933dc

  Copy full SHA for b0933dc

• commands: Simplified Error string output

  mappum

  committed
  ce417cc

  Copy full SHA for ce417cc

• server/http: Set Content-Type header based on command output

  mappum

  committed
  081a936

  Copy full SHA for 081a936

• commands: Added Request#Options so consumers can iterate through provided options

  mappum

  committed
  e42cf33

  Copy full SHA for e42cf33

• cmd/ipfs: Rewrote entry point to invoke commands via new command API

  mappum

  committed
  b1ba383

  Copy full SHA for b1ba383

• cmd/ipfs: Deleted existing CLI commands (to be refactored for the commands API)

  mappum

  committed
  bf1f964

  Copy full SHA for bf1f964

• cmd/ipfs: Added HTTP RPC client to entry point

  mappum

  committed
  0e487ea

  Copy full SHA for 0e487ea

• cmd/ipfs: Added root command for CLI-specific subcommands (init, daemon, etc.)

  mappum

  committed
  7361478

  Copy full SHA for 7361478

• cmd/ipfs: Run CLI-specific subcommands locally in CLI entry point

  mappum

  committed
  1dddee4

  Copy full SHA for 1dddee4

• commands/http: Moved HTTP RPC into commands/http package

  mappum

  committed
  0fd5ae3

  Copy full SHA for 0fd5ae3

• cmd/ipfs: Added ipfs.exe to .gitignore

  mappum

  committed
  be630a8

  Copy full SHA for be630a8

• commands/http: Moved HTTP RPC handler into commands/http

  mappum

  committed
  ff8ad04

  Copy full SHA for ff8ad04

• cmd/ipfs: Added basic daemon command

  mappum

  committed
  6a2b723

  Copy full SHA for 6a2b723

• commands: Silently skip unrecognized options, it should be up to the transport to decide if they cause an error

  mappum

  committed
  d9a7f31

  Copy full SHA for d9a7f31

• commands: Fixed test

  mappum

  committed
  189d813

  Copy full SHA for 189d813

• cmd/ipfs: Do command option conversion in CLI entry point

  mappum

  committed
  47745ed

  Copy full SHA for 47745ed

• cmd/ipfs: Obtain lock when starting daemon

  mappum

  committed
  ad4ddd3

  Copy full SHA for ad4ddd3

• cmd/ipfs: Use lock to check if daemon is running, if not then run command locally

  mappum

  committed
  67fd87f

  Copy full SHA for 67fd87f

• cmd/ipfs: Load API address from config

  mappum

  committed
  342aaf9

  Copy full SHA for 342aaf9

• cmd/ipfs: Added getConfig function

  mappum

  committed
  cef6b3f

  Copy full SHA for cef6b3f

• commands: Added Context() to Request

  mappum

  committed
  ecbd52d

  Copy full SHA for ecbd52d

• commands/http: Made client load RPC host from config

  mappum

  committed
  ea7e1ed

  Copy full SHA for ea7e1ed

• cmd/ipfs: Load config and put in request context

  mappum

  committed
  97c5816

  Copy full SHA for 97c5816

• cmd/ipfs: Made daemon command use request context instead of loading config

  mappum

  committed
  6002137

  Copy full SHA for 6002137

• daemon: Replaced daemon package with lock functions

  mappum

  committed
  11f2f10

  Copy full SHA for 11f2f10

• cmd/ipfs: Use daemon lock functions

  mappum

  committed
  df49b41

  Copy full SHA for df49b41

• commands: Added Request#SetContext()

  mappum

  committed
  1f6aef7

  Copy full SHA for 1f6aef7

• commands/http: Made Handler set request contexts

  mappum

  committed
  5db8753

  Copy full SHA for 5db8753

• cmd/ipfs: Log to show API server is listening

  mappum

  committed
  47aaea8

  Copy full SHA for 47aaea8

• cmd/ipfs: Removed new commands (to be refactored later)

  mappum

  committed
  6798fa0

  Copy full SHA for 6798fa0

• cmd/ipfs: Display help text when help flag is set

  mappum

  committed
  5a72da9

  Copy full SHA for 5a72da9

• server/http: Fixed build error

  mappum

  committed
  3d8dcb3

  Copy full SHA for 3d8dcb3

• cmd/ipfs: Added 'local' flag to call command locally instead of executing on daemon

  mappum

  committed
  6fdfaba

  Copy full SHA for 6fdfaba

• commands/http: Moved http request parsing into a Parse function

  mappum

  committed
  e0fb426

  Copy full SHA for e0fb426

• commands/http: Parse command args

  mappum

  committed
  b35261f

  Copy full SHA for b35261f

• core/commands: Added a 'args' command to test argument parsing

  mappum

  committed
  bcbbad2

  Copy full SHA for bcbbad2

• commands/http: Send request arguments in client requests

  mappum

  committed
  8cff55c

  Copy full SHA for 8cff55c

• commands/http: Use request body as command input stream

  mappum

  committed
  8825814

  Copy full SHA for 8825814

• core/commands: Added 'echo' command that writes input stream to output stream

  mappum

  committed
  2e6b019

  Copy full SHA for 2e6b019

• commands: Gave Requests a reference to the command they are being called on

  mappum

  committed
  f16ca39

  Copy full SHA for f16ca39

• commands: Added a Format function to Command, for creating human-readable output based on a Response

  mappum

  committed
  af75d56

  Copy full SHA for af75d56

• commands: Added plaintext marshalling to Response#Marshal()

  mappum

  committed
  859fc1d

  Copy full SHA for 859fc1d

• commands/http: Explicitly define the MIME types for each encoding

  mappum

  committed
  aeb0dfa

  Copy full SHA for aeb0dfa

• core/commands: Added a Format function for the 'beep' command

  mappum

  committed
  5b0de01

  Copy full SHA for 5b0de01

• commands/http: Don't try to parse HTTP response into a Response, just read the output

  mappum

  committed
  2dae91a

  Copy full SHA for 2dae91a

• cmd/ipfs: Default to plaintext encoding if avilable, otherwise JSON

  mappum

  committed
  8b2f44b

  Copy full SHA for 8b2f44b

• commands: Fixed tests

  mappum

  committed
  b87fc9c

  Copy full SHA for b87fc9c

• commands: Added a Type field for defining output struct formats

  mappum

  committed
  11a8500

  Copy full SHA for 11a8500

• commands/http: Made HTTP client unmarshal response values based on the Command#Type

  mappum

  committed
  1781a75

  Copy full SHA for 1781a75

• core/commands: Added Type to 'beep' command

  mappum

  committed
  220d51c

  Copy full SHA for 220d51c

• cmd/ipfs: Initialize IpfsNode when running locally or starting daemon

  mappum

  committed
  2a93913

  Copy full SHA for 2a93913

• core/commands: Added 'cat' command

  mappum

  committed
  a781986

  Copy full SHA for a781986

• move temporarily

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  d978a15

  Copy full SHA for d978a15

• move originals back to ipfs

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  a98ba90

  Copy full SHA for a98ba90

• move new commands to new place

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  80080c7

  Copy full SHA for 80080c7

• new commands to temp dir

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  81458bd

  Copy full SHA for 81458bd

• original commands to original dir

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  0cfb3f4

  Copy full SHA for 0cfb3f4

• new commands to commands2

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  b9b347e

  Copy full SHA for b9b347e

• remove duplicate files

  Show description for fb9fb15
  

  Brian Tiger Chow

  authored and

  mappum

  committed
  fb9fb15

  Copy full SHA for fb9fb15

• fix(cmd/ipfs2, commands) imports

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  79c049c

  Copy full SHA for 79c049c

• move new daemon to daemon2

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  e8f91b3

  Copy full SHA for e8f91b3

• put original daemon back in place

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  e6af839

  Copy full SHA for e6af839

• fix(cmd/ipfs2/daemon) imports

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  62b663e

  Copy full SHA for 62b663e

• fix(core/commands2) ipfs help message

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  ca56975

  Copy full SHA for ca56975

• chore(Makefile) provide install task

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  c5a46d5

  Copy full SHA for c5a46d5

• fix(commands2/cat) rm extraneous print in output

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  12c257f

  Copy full SHA for 12c257f

• refactor(commands) swap argument order to match Http(w, r) idiom

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  9608b8b

  Copy full SHA for 9608b8b

• refactor(cmd/ipfs2) rename to match cmd/ipfs1

  

  Brian Tiger Chow

  authored and

  mappum

  committed
  c4f08c9

  Copy full SHA for c4f08c9

• cmd/ipfs2: Added init command

  mappum

  committed
  2d06010

  Copy full SHA for 2d06010

• commands: Don't error when marshalling empty Responses

  mappum

  committed
  6e00e47

  Copy full SHA for 6e00e47

• cmd/ipfs2: Changed command variable naming convention

  mappum

  committed
  8549283

  Copy full SHA for 8549283

• cmd/ipfs2: daemon command: Handle lock before initializing node

  mappum

  committed
  9309bdd

  Copy full SHA for 9309bdd

• core/commands2: Added 'ls' command

  mappum

  committed
  2a4afef

  Copy full SHA for 2a4afef

• core/command2: Fixed ls output for XML marshalling

  mappum

  committed
  f5e8868

  Copy full SHA for f5e8868

• commands: Added 'Private' field to Command

  mappum

  committed
  a648f82

  Copy full SHA for a648f82

• cmd/ipfs2: Got rid of second root command in favor of Command#Private

  mappum

  committed
  72728b1

  Copy full SHA for 72728b1

• cmd/ipfs: Moved private commands to core/commands2

  mappum

  committed
  0915f8c

  Copy full SHA for 0915f8c

• commands/http: Pass root command in as field instead of statically depending on core/commands

  mappum

  committed
  4fa135c

  Copy full SHA for 4fa135c

• core/commands2: Added 'commands' command

  mappum

  committed
  73f120e

  Copy full SHA for 73f120e

• commands/http: 404 when trying to call root command

  mappum

  committed
  bce0e48

  Copy full SHA for bce0e48

• commands/http: Improved client error handling

  mappum

  committed
  cd536b1

  Copy full SHA for cd536b1

• commands/http: Error if trying to run private command

  mappum

  committed
  e027373

  Copy full SHA for e027373

• core/commands: Moved commands that were rebased into the wrong directory

  mappum

  committed
  8efa822

  Copy full SHA for 8efa822

• core/commands2: Set root subcommands in init to prevent initialization loops

  mappum

  committed
  3f23779

  Copy full SHA for 3f23779

• commands/cli: Made Parse handle multiple root commands

  mappum

  committed
  f000460

  Copy full SHA for f000460

• commands: Removed Command#Private field

  mappum

  committed
  75d2eed

  Copy full SHA for 75d2eed

• cmd/ipfs: Reverted back to secondary CLI root command

  mappum

  committed
  d7e74e5

  Copy full SHA for d7e74e5

• commands/cli: Error if no subcommand matched

  mappum

  committed
  862c4bf

  Copy full SHA for 862c4bf

• cmd/ipfs: Show usage text if input fails to parse

  mappum

  committed
  3d1fb2e

  Copy full SHA for 3d1fb2e

• core/commands2: Added 'publish' command

  mappum

  committed
  dffa1f8

  Copy full SHA for dffa1f8

Commits on Nov 3, 2014

• commands: Changed Request arguments to a []interface{}

  mappum

  committed
  68fed37

  Copy full SHA for 68fed37

• core/commands2: Removed 'echo' test command

  mappum

  committed
  9299e3d

  Copy full SHA for 9299e3d

• commands: Removed inpout stream from Request

  mappum

  committed
  bb907d3

  Copy full SHA for bb907d3

• commands: Fixed tests

  mappum

  committed
  0d2768b

  Copy full SHA for 0d2768b

• commands/http: Added stream argument handling to client and request parser

  mappum

  committed
  b669824

  Copy full SHA for b669824

• commands: Renamed ArgPath to ArgFile

  mappum

  committed
  ef15c50

  Copy full SHA for ef15c50

• commands/cli: Open argument files when creating Requests (Moved out of HTTP client)

  mappum

  committed
  98cd283

  Copy full SHA for 98cd283

• core/commands2: Added preliminary 'add' command

  mappum

  committed
  32605b3

  Copy full SHA for 32605b3

• Added argument definition to 'cat' command

  mappum

  committed
  fed0792

  Copy full SHA for fed0792

• core/commands2: Added output for 'add' command

  mappum

  committed
  4473e38

  Copy full SHA for 4473e38

• commands: Check argument validity when running commands

  mappum

  committed
  77d3890

  Copy full SHA for 77d3890

• commands/cli: Made parser handle variadic arguments

  mappum

  committed
  5706eb8

  Copy full SHA for 5706eb8

• commands/http: Made parser/client handle variadic arguments

  mappum

  committed
  7a3c26b

  Copy full SHA for 7a3c26b

• core/commands2: Added logging

  mappum

  committed
  efa9322

  Copy full SHA for efa9322

• core/commands2: Added a simple 'message' output/formatter

  mappum

  committed
  4c72647

  Copy full SHA for 4c72647

• core/commands2: Added 'log' command

  mappum

  committed
  5f5f4b0

  Copy full SHA for 5f5f4b0

• commands: Fixed Request#CheckArguments not erroring when required arguments were missing

  mappum

  committed
  11acfcd

  Copy full SHA for 11acfcd

• commands: CLI Parse: Don't parse args until after creating request

  mappum

  committed
  d3d8563

  Copy full SHA for d3d8563

• commands: Moved argument checking into a Command method, fail early when parsing commands

  mappum

  committed
  1467466

  Copy full SHA for 1467466

• core/commands2: Added argument definition for 'ls'

  mappum

  committed
  1c85c3c

  Copy full SHA for 1c85c3c

• commands: Renamed Response#Value to Response#Output

  mappum

  committed
  5752332

  Copy full SHA for 5752332

Commits on Nov 4, 2014

• commands: Return a reader in a Response#Reader method, instead of making Response implementing io.Reader

  mappum

  committed
  08cb80a

  Copy full SHA for 08cb80a

• commands: Cleaned up argument validation

  mappum

  committed
  9d8100a

  Copy full SHA for 9d8100a

• commands/http: Ensure request URLs start with expected prefix

  mappum

  committed
  068d75c

  Copy full SHA for 068d75c

• commands/http: Respond with error if encoding option isn't a string

  mappum

  committed
  3b8a6b7

  Copy full SHA for 3b8a6b7

• commands/http: Unexported Handler fields and created constructor

  mappum

  committed
  5148564

  Copy full SHA for 5148564

• cmd/ipfs2: Stricter option type coercion in main

  mappum

  committed
  509a9e6

  Copy full SHA for 509a9e6

• commands: Nicer syntax for Argument definition

  mappum

  committed
  5cbcfab

  Copy full SHA for 5cbcfab

• cmd/ipfs2: Broke up main into subfunctions

  mappum

  committed
  c1b3c1b

  Copy full SHA for c1b3c1b

• commands/cli: Better comment for parsePath

  mappum

  committed
  8cc1907

  Copy full SHA for 8cc1907

• commands: Replaced 'Formatter' with 'Marshaller'

  mappum

  committed
  a4cb04a

  Copy full SHA for a4cb04a

• commands: Safer type coercion when choosing marshaller

  mappum

  committed
  ba03978

  Copy full SHA for ba03978

• commands: Allow overriding marshaller for any encoding type

  mappum

  committed
  9e9e9da

  Copy full SHA for 9e9e9da

• commands/http: Refactored API to a Client object that takes a string address

  mappum

  committed
  613b4e5

  Copy full SHA for 613b4e5

• commands/http: Cleaner URL formation in client

  mappum

  committed
  0c2c54c

  Copy full SHA for 0c2c54c

• commands/http: Use net/url querystring encoder

  mappum

  committed
  b5320b6

  Copy full SHA for b5320b6

• commands/http: Decomposed Client#Send function

  mappum

  committed
  b3dd962

  Copy full SHA for b3dd962

• commands/http: Renamed variable for clarity

  mappum

  committed
  03119eb

  Copy full SHA for 03119eb

• commands: Fixed panic when trying to marshal without a command set in request

  mappum

  committed
  2d8cd94

  Copy full SHA for 2d8cd94

• commands/http: Cleaned up argument handling in Parse

  mappum

  committed
  55670a5

  Copy full SHA for 55670a5