Code

Commands Refactor Part 1#262

Code

Merged

jbenet merged 66 commits intomasteripfs/kubo:masterfrom cmd-ref-part1ipfs/kubo:cmd-ref-part1Copy head branch name to clipboardNov 4, 2014

+625-74

Commits

Commits on Nov 4, 2014

• commands: Made Response#Error return an *Error instead of an error

  

  mappum

  authored and

  jbenet

  committed
  19e5fba

  Copy full SHA for 19e5fba

• commands: Removed unused output stream field from Response

  

  mappum

  authored and

  jbenet

  committed
  94683bb

  Copy full SHA for 94683bb

• commands: Made Response implement io.Reader

  

  mappum

  authored and

  jbenet

  committed
  3cebd21

  Copy full SHA for 3cebd21

• commands: Simplified Error string output

  

  mappum

  authored and

  jbenet

  committed
  e8b37ac

  Copy full SHA for e8b37ac

• commands: Added Request#Options so consumers can iterate through provided options

  

  mappum

  authored and

  jbenet

  committed
  a65c99e

  Copy full SHA for a65c99e

• commands/http: Moved HTTP RPC into commands/http package

  

  mappum

  authored and

  jbenet

  committed
  8b61daa

  Copy full SHA for 8b61daa

• commands/http: Moved HTTP RPC handler into commands/http

  

  mappum

  authored and

  jbenet

  committed
  43c61a4

  Copy full SHA for 43c61a4

• commands: Silently skip unrecognized options, it should be up to the transport to decide if they cause an error

  

  mappum

  authored and

  jbenet

  committed
  53e1359

  Copy full SHA for 53e1359

• commands: Fixed test

  

  mappum

  authored and

  jbenet

  committed
  b033e33

  Copy full SHA for b033e33

• commands: Added Context() to Request

  

  mappum

  authored and

  jbenet

  committed
  20f86c0

  Copy full SHA for 20f86c0

• commands/http: Made client load RPC host from config

  

  mappum

  authored and

  jbenet

  committed
  48bd73c

  Copy full SHA for 48bd73c

• commands: Added Request#SetContext()

  

  mappum

  authored and

  jbenet

  committed
  289bce6

  Copy full SHA for 289bce6

• commands/http: Made Handler set request contexts

  

  mappum

  authored and

  jbenet

  committed
  29b96b6

  Copy full SHA for 29b96b6

• commands/http: Moved http request parsing into a Parse function

  

  mappum

  authored and

  jbenet

  committed
  52bc8bd

  Copy full SHA for 52bc8bd

• commands/http: Parse command args

  

  mappum

  authored and

  jbenet

  committed
  7531625

  Copy full SHA for 7531625

• commands/http: Send request arguments in client requests

  

  mappum

  authored and

  jbenet

  committed
  42633e5

  Copy full SHA for 42633e5

• commands/http: Use request body as command input stream

  

  mappum

  authored and

  jbenet

  committed
  507192e

  Copy full SHA for 507192e

• commands: Gave Requests a reference to the command they are being called on

  

  mappum

  authored and

  jbenet

  committed
  81f2925

  Copy full SHA for 81f2925

• commands: Added a Format function to Command, for creating human-readable output based on a Response

  

  mappum

  authored and

  jbenet

  committed
  38f8f1c

  Copy full SHA for 38f8f1c

• commands: Added plaintext marshalling to Response#Marshal()

  

  mappum

  authored and

  jbenet

  committed
  b54801c

  Copy full SHA for b54801c

• commands/http: Explicitly define the MIME types for each encoding

  

  mappum

  authored and

  jbenet

  committed
  714e13b

  Copy full SHA for 714e13b

• commands/http: Don't try to parse HTTP response into a Response, just read the output

  

  mappum

  authored and

  jbenet

  committed
  32a2959

  Copy full SHA for 32a2959

• commands: Fixed tests

  

  mappum

  authored and

  jbenet

  committed
  6302356

  Copy full SHA for 6302356

• commands: Added a Type field for defining output struct formats

  

  mappum

  authored and

  jbenet

  committed
  ef290fa

  Copy full SHA for ef290fa

• commands/http: Made HTTP client unmarshal response values based on the Command#Type

  

  mappum

  authored and

  jbenet

  committed
  c0a9871

  Copy full SHA for c0a9871

• fix(cmd/ipfs2, commands) imports

  

  Brian Tiger Chow

  authored and

  jbenet

  committed
  b1bf60b

  Copy full SHA for b1bf60b

• refactor(commands) swap argument order to match Http(w, r) idiom

  

  Brian Tiger Chow

  authored and

  jbenet

  committed
  4911dc0

  Copy full SHA for 4911dc0

• commands: Don't error when marshalling empty Responses

  

  mappum

  authored and

  jbenet

  committed
  b61cfd9

  Copy full SHA for b61cfd9

• commands: Added 'Private' field to Command

  

  mappum

  authored and

  jbenet

  committed
  460387f

  Copy full SHA for 460387f

• commands/http: Pass root command in as field instead of statically depending on core/commands

  

  mappum

  authored and

  jbenet

  committed
  1e0cabd

  Copy full SHA for 1e0cabd

• commands/http: 404 when trying to call root command

  

  mappum

  authored and

  jbenet

  committed
  ea09268

  Copy full SHA for ea09268

• commands/http: Improved client error handling

  

  mappum

  authored and

  jbenet

  committed
  abcebb0

  Copy full SHA for abcebb0

• commands/http: Error if trying to run private command

  

  mappum

  authored and

  jbenet

  committed
  cfa56dd

  Copy full SHA for cfa56dd

• commands/cli: Made Parse handle multiple root commands

  

  mappum

  authored and

  jbenet

  committed
  c0d3edd

  Copy full SHA for c0d3edd

• commands: Removed Command#Private field

  

  mappum

  authored and

  jbenet

  committed
  83b2ba0

  Copy full SHA for 83b2ba0

• commands/cli: Error if no subcommand matched

  

  mappum

  authored and

  jbenet

  committed
  30e9687

  Copy full SHA for 30e9687

• commands: Changed Request arguments to a []interface{}

  

  mappum

  authored and

  jbenet

  committed
  827f1dd

  Copy full SHA for 827f1dd

• commands: Removed inpout stream from Request

  

  mappum

  authored and

  jbenet

  committed
  3a8d60c

  Copy full SHA for 3a8d60c

• commands: Fixed tests

  

  mappum

  authored and

  jbenet

  committed
  39c78fb

  Copy full SHA for 39c78fb

• commands/http: Added stream argument handling to client and request parser

  

  mappum

  authored and

  jbenet

  committed
  40858b4

  Copy full SHA for 40858b4

• commands: Renamed ArgPath to ArgFile

  

  mappum

  authored and

  jbenet

  committed
  f7aa2b9

  Copy full SHA for f7aa2b9

• commands/cli: Open argument files when creating Requests (Moved out of HTTP client)

  

  mappum

  authored and

  jbenet

  committed
  ee2c769

  Copy full SHA for ee2c769

• commands: Check argument validity when running commands

  

  mappum

  authored and

  jbenet

  committed
  e8d0cbf

  Copy full SHA for e8d0cbf

• commands/cli: Made parser handle variadic arguments

  

  mappum

  authored and

  jbenet

  committed
  2c8fc85

  Copy full SHA for 2c8fc85

• commands/http: Made parser/client handle variadic arguments

  

  mappum

  authored and

  jbenet

  committed
  405cfd9

  Copy full SHA for 405cfd9

• commands: Fixed Request#CheckArguments not erroring when required arguments were missing

  

  mappum

  authored and

  jbenet

  committed
  586a019

  Copy full SHA for 586a019

• commands: CLI Parse: Don't parse args until after creating request

  

  mappum

  authored and

  jbenet

  committed
  dbeffb6

  Copy full SHA for dbeffb6

• commands: Moved argument checking into a Command method, fail early when parsing commands

  

  mappum

  authored and

  jbenet

  committed
  75649f3

  Copy full SHA for 75649f3

• commands: Renamed Response#Value to Response#Output

  

  mappum

  authored and

  jbenet

  committed
  69a56de

  Copy full SHA for 69a56de

• commands: Return a reader in a Response#Reader method, instead of making Response implementing io.Reader

  

  mappum

  authored and

  jbenet

  committed
  f6c3888

  Copy full SHA for f6c3888

• commands: Cleaned up argument validation

  

  mappum

  authored and

  jbenet

  committed
  bc6938d

  Copy full SHA for bc6938d

• commands/http: Ensure request URLs start with expected prefix

  

  mappum

  authored and

  jbenet

  committed
  446acdc

  Copy full SHA for 446acdc

• commands/http: Respond with error if encoding option isn't a string

  

  mappum

  authored and

  jbenet

  committed
  4552fce

  Copy full SHA for 4552fce

• commands/http: Unexported Handler fields and created constructor

  

  mappum

  authored and

  jbenet

  committed
  f76048f

  Copy full SHA for f76048f

• commands: Nicer syntax for Argument definition

  

  mappum

  authored and

  jbenet

  committed
  958e524

  Copy full SHA for 958e524

• commands/cli: Better comment for parsePath

  

  mappum

  authored and

  jbenet

  committed
  068e10c

  Copy full SHA for 068e10c

• commands: Replaced 'Formatter' with 'Marshaller'

  

  mappum

  authored and

  jbenet

  committed
  0149f65

  Copy full SHA for 0149f65

• commands: Safer type coercion when choosing marshaller

  

  mappum

  authored and

  jbenet

  committed
  33ad56e

  Copy full SHA for 33ad56e

• commands: Allow overriding marshaller for any encoding type

  

  mappum

  authored and

  jbenet

  committed
  2a1116c

  Copy full SHA for 2a1116c

• commands/http: Refactored API to a Client object that takes a string address

  

  mappum

  authored and

  jbenet

  committed
  5e5d534

  Copy full SHA for 5e5d534

• commands/http: Cleaner URL formation in client

  

  mappum

  authored and

  jbenet

  committed
  33b0990

  Copy full SHA for 33b0990

• commands/http: Use net/url querystring encoder

  

  mappum

  authored and

  jbenet

  committed
  e57cd9b

  Copy full SHA for e57cd9b

• commands/http: Decomposed Client#Send function

  

  mappum

  authored and

  jbenet

  committed
  c8ae4b6

  Copy full SHA for c8ae4b6

• commands/http: Renamed variable for clarity

  

  mappum

  authored and

  jbenet

  committed
  df6c700

  Copy full SHA for df6c700

• commands: Fixed panic when trying to marshal without a command set in request

  

  mappum

  authored and

  jbenet

  committed
  db9c7f7

  Copy full SHA for db9c7f7

• commands/http: Cleaned up argument handling in Parse

  

  mappum

  authored and

  jbenet

  committed
  1b9b603

  Copy full SHA for 1b9b603