Move fetcher feeding to separate goroutine to avoid deadlocking #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voker57
force-pushed
the
enumerate-deadlock-fix
branch
4 times, most recently
from
6ce0746 to
a84fe76
Compare
|
Could you make it panic safe and note use recover? |
|
I'll try. |
License: MIT Signed-off-by: Iaroslav Gridin <[email protected]>
Voker57
force-pushed
the
enumerate-deadlock-fix
branch
from
a84fe76 to
9e12323
Compare
|
@Kubuxu done. CI seems to be broken but my test passed |
|
@Kubuxu lets make sure to review this one thoroughly, this part of the codebase always feels a tad fragile to me |
|
It does and is, as the semaphore change shows. |
|
closed in favor of #3598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnumerateChildrenAsyncis sending slices of keys tofetchNodes, but receives only one node per iteration, which, when coupled with recent addition of concurrency limit, can lead to deadlock whentoprocessis full butnodesis empty. This patch defers feedingtoprocessto separate (unbounded) goroutines to allow concurrent IO between the two functions.Fixes #3505