Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Pinning.RemoteServices: API → Api #7819

Closed
wants to merge 1 commit into from
Closed

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 9, 2020

@aschmahmann @petar

  • v0.8.0-rc1 uses Api, and this PR changes docs to that
  • Api introduces tiny inconsistency across the config, because we already use Addresses.API
    • if you feel its worth changing to API then we still want to merge this PR, and then change both code and docs in RC2

@lidel lidel requested review from petar and aschmahmann December 9, 2020 20:14
@lidel lidel added the topic/docs-ipfs Topic docs-ipfs label Dec 9, 2020
@petar
Copy link
Contributor

petar commented Dec 9, 2020

The Go convention is also to use API, so maybe we should change the go side?

@lidel
Copy link
Member Author

lidel commented Dec 14, 2020

Yup, closing without merging: ipfs/go-ipfs-config#116 will change the config to use API

@lidel lidel closed this Dec 14, 2020
@lidel lidel deleted the docs/api-case branch December 14, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/docs-ipfs Topic docs-ipfs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants