This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: reinstate DAGLink.multihash property with deprecation notice #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Feel free to call me a coward and close this without merging. |
Just having a slight wobble about removing the `.multihash` property from the DAGLink class as part of #99. It's the right thing to do but it will cause a lot of disruption.
achingbrain
force-pushed
the
put-link-multihash-property-back
branch
from
66dde2a to
31e4709
Compare
vmx
reviewed
Nov 12, 2018
There was a problem hiding this comment.
Is the plan to have .multishash back for a while (the near future) or is it just a quick fix to get things our quickly and remove it again soon?
I'm asking if I'd find it cool if we could remove it completely, but I also want to stay practical and not making someone's life artificially more difficult.
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 91.35% 91.41% +0.06%
==========================================
Files 13 13
Lines 266 268 +2
==========================================
+ Hits 243 245 +2
Misses 23 23
Continue to review full report at Codecov.
|
|
Only forward! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just having a slight wobble about removing the
.multihashproperty from the DAGLink class as part of #99. It's the right thing to do but it will cause a lot of disruption.