This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
perf: fixes #97 by not sorting DAGNode links when they are already sorted #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
approved these changes
Oct 30, 2018
vmx
approved these changes
Oct 31, 2018
vmx
suggested changes
Oct 31, 2018
There was a problem hiding this comment.
Commit lint failed https://ci.ipfs.team/blue/organizations/jenkins/IPLD%2Fjs-ipld-dag-pb/detail/PR-98/1/pipeline/269. Subject is too long.
achingbrain
force-pushed
the
do-not-sort-links-unnecessarily
branch
from
f003847 to
ccf8b5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 90.8% 90.28% -0.53%
==========================================
Files 13 13
Lines 272 278 +6
==========================================
+ Hits 247 251 +4
- Misses 25 27 +2
Continue to review full report at Codecov.
|
|
@vmx have updated the commit message |
achingbrain
force-pushed
the
do-not-sort-links-unnecessarily
branch
from
ccf8b5e to
20f4cae
Compare
vmx
suggested changes
Nov 2, 2018
There was a problem hiding this comment.
@achingbrain Can you please add a test for serialize() with an invalid node? I don't think we need to cover all error branches, but I haven't found a single test for invalid data.
vmx
approved these changes
Nov 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #97 for context. Essentially when we are deserializing a DAGNode from a buffer, the links should already be sorted so just new up a DAGNode object and return it. Though we still have to calculate what the CID was that may have been used to load this DAGNode. See ipld/js-ipld#173 for further discussion on that point.