[DispatchCreation] Collapse dynamic dims #19654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
changed the title
IanWood1
force-pushed
the
dynamic_dim_changes
branch
2 times, most recently
from
13452de to
62c2e1e
Compare
|
Looks like the first two patches landed in some form. llvm/llvm-project#118208 is ready for review, so we can make progress on this patch soon. |
IanWood1
force-pushed
the
dynamic_dim_changes
branch
4 times, most recently
from
c251291 to
3a45312
Compare
|
Thank you @Groverkss ! |
|
The upstream PR seems close to landing so I'll mark this ready for review. |
IanWood1
force-pushed
the
dynamic_dim_changes
branch
from
3a45312 to
2d22746
Compare
MaheshRavishankar
approved these changes
Feb 13, 2025
This seemed to cause regressions because divisibility information seemed to be lost and BlockDynamicDims couldn't block the dynamic dims of matmuls. First I tried running OptimizeIntArithmetic before regions to workgroups which helped fix an issue with int range optimizations, then I removed OptimizeIntArithmetic and just expand affine ops after reifying dynamic dims (which was also good perf-wise). Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
IanWood1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable collapsing dynamic dimensions in
CollapseDimensionsPassI'm fairly certain that the issue with the sharktank tests is unrelated toCollapseDimensions, I fully disabled it an still hit the same error. A similar issue was experienced when testing IREE with llvm/llvm-project#113501. This was ran on CI on commit 62b4c1c (see parent commit for llvm submodule change)