Changes to dispatch formation to allow for fusion with trunc in case of gemm + transpose gemm fusion #20055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of gemm + transpose gemm fusion. Signed-off-by: MaheshRavishankar <[email protected]>
IanWood1
reviewed
Feb 21, 2025
compiler/src/iree/compiler/DispatchCreation/FormDispatchRegions.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/DispatchCreation/FormDispatchRegions.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/DispatchCreation/test/form_dispatch_regions.mlir
Outdated
Show resolved
Hide resolved
|
Could you also reduce the clip dispatch count? It seems to have substantially decreased |
MaheshRavishankar
force-pushed
the
shared/noconcatHorizontalFusionDispatchRegionFixed
branch
from
454adc6 to
a0df06d
Compare
Signed-off-by: MaheshRavishankar <[email protected]>
MaheshRavishankar
force-pushed
the
shared/noconcatHorizontalFusionDispatchRegionFixed
branch
from
a0df06d to
039f735
Compare
IanWood1
approved these changes
Feb 21, 2025
|
The regressions here seemed to have been fixed with #20060 . Ill land these changes with that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.