Increase size of the PotentialValuesState. #20119
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvanik
approved these changes
Feb 27, 2025
When running the ElideTimepoints pass on a large program (llama 8b for example) we exhaust our state, and fail to elide timepoints. This significantly reduces the number of timepoints that end up in the waiting set in those cases. Signed-off-by: Andrew Woloszyn <[email protected]>
AWoloszyn
force-pushed
the
increase-potential-values
branch
from
60bf567 to
14e8c7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the ElideTimepoints pass on a large program (llama 8b for example) we exhaust our state, and fail to elide timepoints.
This significantly reduces the number of timepoints that end up in the waiting set in those cases.
The number of timepoint waits in the stream output are as follows.