[DT] Hoist constant source out of dispatch in HoistEncodingOps pass. #20125
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The small constants can be inlined into dispatches, and they could become the source of `set_encoding` ops. The revision adds the support for hoisting both operations out if the source is a constant. Signed-off-by: hanhanW <[email protected]>
benvanik
reviewed
Feb 27, 2025
There was a problem hiding this comment.
heads up that you're going to want something more sophisticated - something along the lines of what we do for constexpr hoisting (you want to see if the entire slice of IR up to the root is constant-like and hoist the entire thing, not peepholing on the source of a set encoding op) - if this works (when not just looking at integers - thinking f16/fp8/etc) then fine for now
| @@ -204,7 +204,14 @@ void HoistEncodingOpsPass::runOnOperation() { | |||
| }); | |||
| IRRewriter rewriter(ctx); | |||
| for (auto setEncodingOp : candidates) { | |||
| Value src = setEncodingOp.getSource(); | |||
| if (getConstantIntValue(src).has_value() && | |||
There was a problem hiding this comment.
you want more than integers - you only care that the source is ConstantLike and can check for that (something like getDefiningOp()->hasTrait<ConstantLike>(), probably)
There was a problem hiding this comment.
Oh, thanks for pointing it out. I missed that the method only works for integers.
Signed-off-by: hanhanW <[email protected]>
Signed-off-by: hanhanW <[email protected]>
benvanik
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The small constants can be inlined into dispatches, and they could become the source of
set_encodingops. The revision adds the support for hoisting both operations out if the source is a constant.