R4R: Fix infinite gas meter utilization during aborted ante handler executions #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifengxi
requested review from
MrXJC,
haifengxi,
kidinamoto01 and
wukongcheng
haifengxi
approved these changes
Jan 15, 2019
wukongcheng
reviewed
Jan 16, 2019
| // prior to returning. | ||
| ctx = newCtx.WithMultiStore(ms) | ||
| } | ||
|
|
||
| if abort { |
There was a problem hiding this comment.
This change will make the newCtx.GasMeter().ConsumeGas(auth.BlockStoreCostPerByte * sdk.Gas(len(txBytes)), "blockstore") do not work. Because the ConsumeGas works on newCtx, not the ctx = newCtx.WithMultiStore(ms).
There was a problem hiding this comment.
msCache.Write() will write the gas comsumtion to real store.
wukongcheng
approved these changes
Jan 16, 2019
wukongcheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge: cosmos/cosmos-sdk#3244
This issue is not severe for us. Because we don't plan to enable block gas limit.