Skip to content

Commit

Permalink
Update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
dguenther committed May 23, 2024
1 parent 0667ed3 commit 540e75a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
11 changes: 7 additions & 4 deletions ironfish/src/rpc/routes/wallet/addKnownTransactions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('Route wallet/addKnownTransactions', () => {
await expect(routeTest.chain).toAddBlock(block)
expect((await routeTest.wallet.getBalance(account, Asset.nativeId())).available).toBe(0n)

account.updateSyncingEnabled(false)
await account.updateScanningEnabled(false)

const response = await routeTest.client.wallet.addKnownTransactions({
account: account.name,
Expand Down Expand Up @@ -74,7 +74,7 @@ describe('Route wallet/addKnownTransactions', () => {
await expect(routeTest.chain).toAddBlock(block)
await expect(account.getHead()).resolves.toBeNull()

account.updateSyncingEnabled(false)
await account.updateScanningEnabled(false)

await expect(() =>
routeTest.client.wallet.addKnownTransactions({
Expand All @@ -90,13 +90,16 @@ describe('Route wallet/addKnownTransactions', () => {

it('throws if gap between start and account head', async () => {
const account = await useAccountFixture(routeTest.wallet, 'foo')
await routeTest.wallet.updateHead()

const block1 = await useMinerBlockFixture(routeTest.chain, undefined, account)
await expect(routeTest.chain).toAddBlock(block1)
const block2 = await useMinerBlockFixture(routeTest.chain, undefined, account)
await expect(routeTest.chain).toAddBlock(block2)

expect((await account.getHead())?.hash).toEqualBuffer(routeTest.chain.genesis.hash)

account.updateSyncingEnabled(false)
await account.updateScanningEnabled(false)

await expect(() =>
routeTest.client.wallet.addKnownTransactions({
Expand All @@ -115,7 +118,7 @@ describe('Route wallet/addKnownTransactions', () => {
await routeTest.wallet.updateHead()
expect((await account.getHead())?.hash).toEqualBuffer(block1.header.hash)

account.updateSyncingEnabled(false)
await account.updateScanningEnabled(false)

const response = await routeTest.client.wallet.addKnownTransactions({
account: account.name,
Expand Down
4 changes: 2 additions & 2 deletions ironfish/src/rpc/routes/wallet/addKnownTransactions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ routes.register<typeof AddKnownTransactionsRequestSchema, AddKnownTransactionsRe
// Validate account state
const account = getAccount(context.wallet, request.data.account)

if (account.syncingEnabled) {
if (account.scanningEnabled) {
throw new RpcResponseError(
`Cannot add known transactions while account syncing is enabled. Try calling wallet/stopSyncing first.`,
`Cannot add known transactions while account syncing is enabled. Try calling wallet/stopScanning first.`,
RPC_ERROR_CODES.ERROR,
409,
)
Expand Down

0 comments on commit 540e75a

Please sign in to comment.