Move ceremony command to R2 #3648
Conversation
| required: false, | ||
| description: 'Prefix for contribution download URLs', | ||
| // TODO: update this to non-dev endpoint to avoid rate limiting | ||
| default: 'https://pub-6a239e04e140459087cf392ffc3245b1.r2.dev', |
There was a problem hiding this comment.
This isn't the bucket, right? I assume it's like an account name
There was a problem hiding this comment.
its the dev testing url. We will replace it with ironfish.network domain name when close to launch.
There was a problem hiding this comment.
Yea that is basically a link to the bucket
| secretAccessKey: credentials.r2SecretAccessKey, | ||
| }, | ||
| }) | ||
| } |
There was a problem hiding this comment.
These are binary compatible with S3, so I wouldnt expect this to exist. There is no difference in the client. I would just expect these to be parameters that you pass into getS3Client but we can refactor this later.
There was a problem hiding this comment.
which things would be parameters?
| } | ||
|
|
||
| export async function getR2Credentials(): Promise<R2Secret | undefined> { | ||
| const client = new SecretsManagerClient({ region: 'us-east-1' }) |
There was a problem hiding this comment.
I am not sure about this region config. If the ceremony server has terraform config, it prob wont need it.
Maybe try it without region on the github workflow
Summary
For cost saving we are moving future trusted setup ceremonies to use Cloudflare R2 instead of S3
Testing Plan
Locally tested a few contributions
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.