Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update httpAdapter: no requirement that a caller use POST #3669

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

EvanJRichard
Copy link
Contributor

@EvanJRichard EvanJRichard commented Mar 20, 2023

Summary

This PR just removes the restriction that http rpc callers use POST.

Testing Plan

Poked around in curl, all seems to work fine.

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes
[X] No

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes
[X] No

just remove the post restriction
@EvanJRichard EvanJRichard self-assigned this Mar 20, 2023
@EvanJRichard EvanJRichard marked this pull request as ready for review March 20, 2023 18:53
@EvanJRichard EvanJRichard requested a review from a team as a code owner March 20, 2023 18:53
@EvanJRichard
Copy link
Contributor Author

Was just talking this out with @danield9tqh : @NullSoldier , should we gate these to POST and GET, or just generally do no verb restrictions?

@holahula
Copy link
Contributor

holahula commented Mar 20, 2023

How does this work with endpoints that require input parameters? I.e. chain/estimateFeeRate where a priority can be inputted? Are they read from the body of the GET request?

@EvanJRichard
Copy link
Contributor Author

@holahula yeah, exactly, for example curl -d '{"sequence": 1}' -X GET http://localhost:8021/chain/getBlock works fine

@EvanJRichard EvanJRichard merged commit e90d4a0 into staging Mar 23, 2023
@EvanJRichard EvanJRichard deleted the no-http-verb-restriction branch March 23, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants