Combine docker deploy workflows #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
approved these changes
Mar 27, 2023
hughy
reviewed
Mar 27, 2023
|
|
||
| # Used if we are deploying a new version (e.g. v1.1) | ||
| # This is only executed when deploying a new release to mainnet | ||
| - name: Deploy Node Image to GitHub:${{ github.ref_name }} |
There was a problem hiding this comment.
What does github.ref_name refer to if this is triggered by workflow_dispatch?
There was a problem hiding this comment.
Chatted with Daniel
the branch is always an input to workflow_dispatch, so this will refer to the branch that you run the workflow from
hughy
approved these changes
Mar 27, 2023
danield9tqh
deleted the
daniel/ifl-283-make-single-github-action-for-deploying
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently have 3 docker deploy workflows when running a release. Each of these builds the docker image separately (which is a lengthy process) and then pushes to the respective docker registry (AWS, GHCR). Combining all 3 into one with options will allow us to only build the docker image once.
This PR is also updating the canonical docker tag names for releases. Previously there was only one docker tag (
latest) which every production node pulled from. In this PR we are addingmainnetandtestnetdocker tags to distinguish between the two networks after mainnet launch.Testing Plan
Tested running the actions on a branch uploading to AWS
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.