adds hash to response of wallet/postTransaction #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendTransaction includes the hash in its responses, but postTransaction does not. a client _could_ hash the output themselves, but this adds an extra step and perhaps an extra dependency for the client.
EvanJRichard
approved these changes
Apr 10, 2023
| @@ -27,6 +27,7 @@ describe('Route wallet/postTransaction', () => { | |||
|
|
|||
| expect(addSpy).toHaveBeenCalledTimes(0) | |||
| expect(response.status).toBe(200) | |||
| expect(response.content.hash).toBeDefined() | |||
There was a problem hiding this comment.
Is it worth it to calculate what the hash should be and check equality, do you think?
There was a problem hiding this comment.
It's a little tricky to do this: there's randomness involved in posting transactions, so posting the same raw transaction twice will result in two different hashes 😓
There was a problem hiding this comment.
Ah, true. Forget it, then, imo.
danield9tqh
approved these changes
Apr 10, 2023
NullSoldier
reviewed
Apr 10, 2023
| @@ -27,6 +27,7 @@ describe('Route wallet/postTransaction', () => { | |||
|
|
|||
| expect(addSpy).toHaveBeenCalledTimes(0) | |||
| expect(response.status).toBe(200) | |||
| expect(response.content.hash).toBeDefined() | |||
There was a problem hiding this comment.
Suggested change
| expect(response.content.hash).toBeDefined() | |
| expect(response.content.hash).toBe(expect.any(String)) |
There was a problem hiding this comment.
I don't think this works in Jest with toBe. It seems like CI is failing with this.
NullSoldier
approved these changes
Apr 10, 2023
Co-authored-by: Jason Spafford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sendTransaction includes the hash in its responses, but postTransaction does not.
a client could hash the output themselves, but this adds an extra step and perhaps an extra dependency for the client.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.