Namespace all routes inside of RPCClient #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
force-pushed
the
jason/rpcclient
branch
from
c4d7c2a to
3b980c6
Compare
this should make the client a bit nicer to use, because you can just look at each object there and find all the chain apis under chain. You also can now just name things in a lot simpler ways. We should start renaming routes to remove the namespace from the route if its duplicated.
NullSoldier
force-pushed
the
jason/rpcclient
branch
from
3b980c6 to
e3192e3
Compare
rohanjadvani
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should make the client a bit nicer to use, because you can just look at each object there and find all the chain apis under chain. You also can now just name things in a lot simpler ways. We should start renaming routes to remove the namespace from the route if its duplicated.
Testing Plan
It only changes the client which should get caught in builds.
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.
Need to add a note about this in the release notes.