Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add memo to interactive mode and display it in confirmation #3815

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

mat-if
Copy link
Contributor

@mat-if mat-if commented Apr 21, 2023

Summary

image

image

Closes IFL-690

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@mat-if mat-if requested a review from a team as a code owner April 21, 2023 16:39
Copy link
Contributor

@EvanJRichard EvanJRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One UX question, but looks right to me.

@mat-if mat-if merged commit b352664 into staging Apr 21, 2023
@mat-if mat-if deleted the mat/send-memo branch April 21, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants