Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ironfish): add note hash to wallet/getAccountNotesStream RPC #3831

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

holahula
Copy link
Contributor

@holahula holahula commented Apr 24, 2023

Summary

Adds note hash to wallet/getAccountNotesStream RPC

Closes IFL-718

Testing Plan

Existing unit tests

➜  ironfish git:(holahula/feat/add-hash-to-note-stream) fish wallet:notes -d ~/.ironfish-simulator/node-1c55 --columns="Memo","Sender","Note Hash","From Transaction"
yarn run v1.22.19
$ yarn build && yarn start:js wallet:notes -d /Users/austino/.ironfish-simulator/node-1c55 '--columns=Memo,Sender,Note Hash,From Transaction'
$ tsc -b
$ cross-env OCLIF_TS_NODE=0 IRONFISH_DEBUG=1 node --expose-gc --inspect=:0 --inspect-publish-uid=http --enable-source-maps bin/run wallet:notes -d /Users/austino/.ironfish-simulator/node-1c55 '--columns=Memo,Sender,Note Hash,From Transaction'
 Memo                             Sender                                                   Note Hash                                                        From Transaction
 ──────────────────────────────── ──────────────────────────────────────────────────────── ──────────────────────────────────────────────────────────────── ────────────────────────────────────────────────────────────────
 default memo                     d6ab204e37848c7bfe8d2cd7b10d4cf0764cfe06758f6d2c149bafd… 9734dbbb4f150d750df3c03b83eab393145b1497777dbaa58b59ba7fb4f63b1b c281b0c4d283c2a93f9b011b925aa8716464ee59a5f1ffa317302a1ac83071e7
 default memo                     d6ab204e37848c7bfe8d2cd7b10d4cf0764cfe06758f6d2c149bafd… 92d439dcde290071ce0ffbf20177ed5c34067e5aa5e9e6958f96e326862f905b fef0ec665dcd672485040547677c200a226f30d5d486abc944ac80fe4d34886c
 default memo                     d6ab204e37848c7bfe8d2cd7b10d4cf0764cfe06758f6d2c149bafd… 0d00426e47b23d2f3097989a0fc3433983528aedfd9ef6ea5fb1c4a57c39ea23 f65f116dd8c58b27a2965d36b7eb40f21e8dc74668d4372e08aaec13d78eb960
 default memo                     d6ab204e37848c7bfe8d2cd7b10d4cf0764cfe06758f6d2c149bafd… eb68b3eda50023da670ab2010f4bee2c626f12e4198f5030f2552ac8dae6a101 459a5b814679c32d2ffc5ccb9521c88679e75073c5e539dc7a896dcf28ded1db
 default memo                     d6ab204e37848c7bfe8d2cd7b10d4cf0764cfe06758f6d2c149bafd… 67faa8ec65bbefdeff1fa4a2d82c026b4f79d776a6096204b03b84767fe18f62 cc5885c150504865be4b1facb8b52f8bb994dc7ff54ee7208b0542978349c414

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ X ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@holahula holahula changed the title feat(ironfish): add note hash to account notes stream rpc feat(ironfish): add note hash to wallet/getAccountNotesStream RPC Apr 24, 2023
@holahula holahula marked this pull request as ready for review April 24, 2023 17:11
@holahula holahula requested a review from a team as a code owner April 24, 2023 17:11
Copy link
Contributor

@hughy hughy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about whether this should be called hash since it's already on a note, or noteHash to match transactionHash.

I'm leaning towards noteHash

@holahula
Copy link
Contributor Author

I'm on the fence about whether this should be called hash since it's already on a note, or noteHash to match transactionHash.

I'm leaning towards noteHash

I kept it as noteHash so that it matches transactionHash

@jowparks jowparks self-requested a review April 24, 2023 19:16
@jowparks jowparks merged commit 3b1735e into staging Apr 24, 2023
@jowparks jowparks deleted the holahula/feat/add-hash-to-note-stream branch April 24, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants