Refactor chain/getTransaction #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygao76
reviewed
Apr 24, 2023
| @@ -39,3 +41,11 @@ export type RpcSpend = { | |||
| commitment: string | |||
| size: number | |||
| } | |||
|
|
|||
| export const RpcSendSchema: yup.ObjectSchema<RpcSpend> = yup | |||
There was a problem hiding this comment.
Can you rename it to RpcSpendSchema
ygao76
reviewed
Apr 24, 2023
| serialized: note.serialize().toString('hex'), | ||
| })) | ||
| if (!foundTransaction) { | ||
| throw new ValidationError( |
There was a problem hiding this comment.
NotFound error fits better than Validation. In general Validation error (INVALID_ARGUMENT) indicates arguments that are problematic regardless of the state of the system (e.g., a malformed file name).
ygao76
reviewed
Apr 24, 2023
| })) | ||
| if (!foundTransaction) { | ||
| throw new ValidationError( | ||
| `Transaction not found on block ${blockHashBuffer.toString('hex')}`, |
There was a problem hiding this comment.
Can you add a unit test on this
ygao76
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't return an empty transaction object if the transaction is not found, instead throw an error. Also added some other small code improvements
Testing Plan
Tested on local RPC
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.