Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli text for transaction:watch #3853

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

wd021
Copy link
Contributor

@wd021 wd021 commented Apr 26, 2023

Summary

Fix #3823. Remove unnecessary Current status... ! from transaction:watch when status is already in desired state.

Before -

wd021:~# ironfish wallet:transaction:watch abcd
Transaction abcd is confirmed
Current Status... !

After -

wd021:~# ironfish wallet:transaction:watch abcd
Transaction abcd is confirmed

Testing Plan

Run wallet:transaction:watch for confirmed transaction

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@wd021 wd021 requested a review from a team as a code owner April 26, 2023 13:54
Copy link
Contributor

@hughy hughy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks!

@hughy hughy merged commit 02ce24c into iron-fish:staging Apr 26, 2023
@dguenther dguenther mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants