ifl-744 add test/updates for calculating raw transaction size #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
joe/ifl-744/rawtransaction-size-test
branch
2 times, most recently
from
c449091 to
53b3fe2
Compare
jowparks
commented
Apr 26, 2023
jowparks
commented
Apr 26, 2023
jowparks
force-pushed
the
joe/ifl-744/rawtransaction-size-test
branch
2 times, most recently
from
d09b594 to
2b6b6b8
Compare
mat-if
approved these changes
Apr 26, 2023
hughy
reviewed
Apr 26, 2023
jowparks
force-pushed
the
joe/ifl-744/rawtransaction-size-test
branch
from
2b6b6b8 to
ab0cfa6
Compare
jowparks
force-pushed
the
joe/ifl-744/rawtransaction-size-test
branch
from
ab0cfa6 to
170c343
Compare
dguenther
requested changes
Apr 27, 2023
dguenther
reviewed
Apr 27, 2023
dguenther
reviewed
Apr 27, 2023
jowparks
force-pushed
the
joe/ifl-744/rawtransaction-size-test
branch
2 times, most recently
from
698405b to
1143157
Compare
jowparks
commented
Apr 28, 2023
| @@ -84,6 +84,10 @@ describe('RawTransaction', () => { | |||
| const mintedValue = valuesByAsset.get(asset.id()) | |||
| Assert.isNotUndefined(mintedValue) | |||
| expect(mintedValue).toEqual(1n) | |||
There was a problem hiding this comment.
This is a nice future proofing test
ygao76
reviewed
Apr 28, 2023
danield9tqh
reviewed
Apr 28, 2023
jowparks
force-pushed
the
joe/ifl-744/rawtransaction-size-test
branch
from
1143157 to
31bccef
Compare
ygao76
approved these changes
Apr 28, 2023
danield9tqh
approved these changes
Apr 28, 2023
dguenther
approved these changes
May 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates size to match https://github.com/iron-fish/ironfish/blob/master/ironfish/src/primitives/transaction.ts#L44
We have to account for change notes as well. We can determine if there will be change for each asset by calculating the total spends/mints/burns/outputs. If they equal 0, there will be no change note
Testing Plan
tests pass
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.