feat(ifl-774): asset constructor use public address #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
joe/ifl-774/asset-constructor-public-address
branch
from
a601146 to
fb12b3e
Compare
jowparks
force-pushed
the
joe/ifl-774/asset-constructor-public-address
branch
from
fb12b3e to
2f4ba91
Compare
mat-if
approved these changes
Apr 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The signature for
Assetconstructor was taking spending key, but it immediately converted it to public address in napi method. Having this take the public address instead allows us to calculateRawTransactionsize deterministically without the spending key. Which means we can calculate size of a transaction with a view only wallet.Testing Plan
Tests pass
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Any user of the ecosystem that is constructing an
Assetmanually will break. I think it is unlikely anyone is doing this yet.