Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for PostTransaction in workers:status #3865

Merged
merged 1 commit into from
Apr 28, 2023
Merged

feat: add support for PostTransaction in workers:status #3865

merged 1 commit into from
Apr 28, 2023

Conversation

holahula
Copy link
Contributor

@holahula holahula commented Apr 28, 2023 •
edited
Loading

Summary

PostTransaction was missing in workers:status in everywhere but display, this adds support for it

Closes IFL-649

Testing Plan

Workers: STARTED - 0 -> 1 / 6 - -0.08 jobs Δ, 12.68 jobs/s

JOB                  | QUEUE | EXECUTE | ERROR | DONE
CreateMinersFee      |     0 |       0 |     0 | 37
DecryptNotes         |     0 |       0 |     0 | 99
PostTransaction      |     0 |       1 |     0 | 6
SubmitTelemetry      |     0 |       0 |     0 | 0
VerifyTransaction    |     0 |       0 |     0 | 0
VerifyTransactions   |     0 |       0 |     0 | 109

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@holahula holahula marked this pull request as ready for review April 28, 2023 19:53
@holahula holahula requested a review from a team as a code owner April 28, 2023 19:53
@holahula holahula requested a review from rohanjadvani April 28, 2023 19:53
@holahula holahula changed the title feat: add support for PostTransactions in workers:status feat: add support for PostTransaction in workers:status Apr 28, 2023
@jowparks
Copy link
Contributor

Nice, this would have been real nice for airdrop 😅

@holahula holahula merged commit 2d5f9a7 into staging Apr 28, 2023
@holahula holahula deleted the holahula/feat/workers-status-post-transaction branch April 28, 2023 21:42
@dguenther dguenther mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jowparks jowparks jowparks approved these changes

@rohanjadvani rohanjadvani Awaiting requested review from rohanjadvani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holahula @jowparks