creates spend witnesses using confirmation range #3918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughy
force-pushed
the
feature/ifl-879/spend-confirmations
branch
from
cd4faf5 to
84080ca
Compare
supports creating spends with a confirmation range. if a spend is created with the chain head at some block A and the chain reorgs to block B, then the spends created at block A will be invalid because the commitment won't match the root hash of the notes tree at that note size. using the note tree size from a confirmed block instead of the current chain head will reduce the likelihood that a reorg will render a spend invalid.
hughy
force-pushed
the
feature/ifl-879/spend-confirmations
branch
from
84080ca to
9861bd5
Compare
jowparks
pushed a commit
that referenced
this pull request
Jun 21, 2023
supports creating spends with a confirmation range. if a spend is created with the chain head at some block A and the chain reorgs to block B, then the spends created at block A will be invalid because the commitment won't match the root hash of the notes tree at that note size. using the note tree size from a confirmed block instead of the current chain head will reduce the likelihood that a reorg will render a spend invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
supports creating spends with a confirmation range. if a spend is created with the chain head at some block A and the chain reorgs to block B, then the spends created at block A will be invalid because the commitment won't match the root hash of the notes tree at that note size.
using the note tree size from a confirmed block instead of the current chain head will reduce the likelihood that a reorg will render a spend invalid.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.