removes loops from getNewBlockTransactions #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughy
force-pushed
the
feature/template-tx-loops
branch
from
ce6c63e to
c9768a1
Compare
when creating a new block template the mining manager collects a list of transactions to include in the block. the mining manager iterates over transactions in the mempool, verifies the spends in the transactions, and tracks the total size and total fee from included transactions. we currently iterate over the list of included transactions twice after collecting them: once to read the fee from the transaction and again to sum the fees. these changes remove the extra iteration over transactions for fees. performance gains will likely be neglible.
hughy
force-pushed
the
feature/template-tx-loops
branch
from
c9768a1 to
4da6f7e
Compare
danield9tqh
approved these changes
Jun 14, 2023
jowparks
pushed a commit
that referenced
this pull request
Jun 21, 2023
when creating a new block template the mining manager collects a list of transactions to include in the block. the mining manager iterates over transactions in the mempool, verifies the spends in the transactions, and tracks the total size and total fee from included transactions. we currently iterate over the list of included transactions twice after collecting them: once to read the fee from the transaction and again to sum the fees. these changes remove the extra iteration over transactions for fees. performance gains will likely be neglible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when creating a new block template the mining manager collects a list of transactions to include in the block.
the mining manager iterates over transactions in the mempool, verifies the spends in the transactions, and tracks the total size and total fee from included transactions.
we iterate over the list of included transactions twice after collecting them: once to read the fee from the transaction and again to sum the fees.
these changes remove the extra iterations over included transactions. performance gains will be neglible.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.