Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli,ironfish): Add wallet:multisig:dkg:round3 #4905

Conversation

rohanjadvani
Copy link
Member

Summary

  • Returns name and public address from round3 rpc endpoint
  • Adds CLI command for dkg round 3

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

@rohanjadvani rohanjadvani self-assigned this Apr 17, 2024
@rohanjadvani rohanjadvani requested a review from a team as a code owner April 17, 2024 22:59
Copy link
Contributor

@hughy hughy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a followup task -- we should support a way to choose a different name other than the secretName for the account

@andiflabs
Copy link
Contributor

for a followup task -- we should support a way to choose a different name other than the secretName for the account

Yes, I initially included this functionality in the RPC, but then discovered that the name was being overridden in the SDK, but now that #4903 is merged we can add this functionality back

@rohanjadvani rohanjadvani merged commit 522cd38 into staging Apr 18, 2024
11 checks passed
@rohanjadvani rohanjadvani deleted the rohan/ifl-2395-cli-implementation-walletmultisigdkground3 branch April 18, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants