Add syncingEnabled migration #4952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
force-pushed
the
start-stop-syncing
branch
from
3c8f732 to
29b54d0
Compare
NullSoldier
force-pushed
the
jason/syncing-migration
branch
4 times, most recently
from
6c35a07 to
9bfa6bc
Compare
NullSoldier
changed the title
NullSoldier
force-pushed
the
jason/syncing-migration
branch
from
9bfa6bc to
0ba496b
Compare
NullSoldier
changed the base branch from
start-stop-syncing
to
jason/persist-account-scanning
dguenther
approved these changes
May 22, 2024
Base automatically changed from
jason/persist-account-scanning
to
start-stop-syncing
May 22, 2024 22:05
NullSoldier
force-pushed
the
jason/syncing-migration
branch
from
f5cd685 to
9cb231d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds migration 032 to add a new field to AccountValue called
scanningEnabledwhich is going to be used for controlling if an account should scan or not.Testing Plan
Run the migration and check the DB to see if the value persist or not.
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.