Rahul/ifl 2581 bug watch command watches expired transactions #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
reviewed
May 16, 2024
| @@ -488,8 +491,8 @@ export async function watchTransaction(options: { | |||
| let currentStatus = prevStatus | |||
|
|
|||
| // If the transaction is already in the desired state, return | |||
| if (currentStatus === waitUntil) { | |||
| logger.log(`Transaction ${options.hash} is ${waitUntil}`) | |||
| if (currentStatus !== 'not found' && waitUntil.includes(currentStatus)) { | |||
There was a problem hiding this comment.
Why is currentStatus !== 'not found' necessary?
There was a problem hiding this comment.
It was a weird type issue because of the assignment above. It was introduced here: https://github.com/iron-fish/ironfish/pull/3726/files . Probably not the best initial implementation tbh. I can look into fixing it but might be out of scope of this PR?
andiflabs
approved these changes
May 28, 2024
patnir
deleted the
rahul/ifl-2581-bug-watch-command-watches-expired-transactions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We treat the expired transaction state as an intermediate state like pending/ unconfirmed. It should be an end state of a transaction.
Before:
send command:
watch:command:
Now:
watch command:
send command:
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.