update parsing of chainport status API to new interface #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patnir
commented
Jun 10, 2024
| const transaction = response.content.transaction | ||
|
|
There was a problem hiding this comment.
this change is just to replace response.content.transaction everywhere
hughy
approved these changes
Jun 11, 2024
patnir
force-pushed
the
rahul/ifl-2652-update-chainport-status-api
branch
from
1af0660 to
3c48d82
Compare
patnir
force-pushed
the
rahul/ifl-2652-update-chainport-status-api
branch
from
d9260d7 to
e7ced6c
Compare
hughy
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chainport just sent us some new information about how to use the transaction status API. These changes reflect the new interaction.
There is also a difference in types. Chainport either sends us an empty object or a body with all keys that either have a type of string or null.
Examples below:
Pending transaction:
Confirmed transaction:
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.