Use inquirer for confirm prompt
#5061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-if
force-pushed
the
mat/confirm
branch
2 times, most recently
from
6152956 to
e2d7472
Compare
This also creates an abstraction for the confirm prompt so it is easier to use confirm logic in commands
NullSoldier
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This also creates an abstraction for the confirm prompt as well as a confirm-or-quit function so it is easier to use confirm logic in commands
This is part of oclif 4.x upgrade prep
Trade-offs
We're trading our manually-added "Do you confirm (Y)es/(N)o" for the library appended "(Y/n)". There is no easy way to override this, short of upgrading the version of inquirer we use. However, the new version of inquirer is an ECMAScript Module, which on its own is solvable, but on top of that, the
@types/inquirerlibrary is quite outdated, which would require us to write our own types to use it, which is more work than it is worth right now.Testing Plan
Manual testing
Documentation
N/A
Breaking Change
N/A