adds ledger utility class #5099
Conversation
|
|
||
| return response.publicAddress.toString('hex') | ||
| } | ||
|
|
There was a problem hiding this comment.
Why isn't this in the sdk and consumed by CLI? This could potentially be useful for other developers
There was a problem hiding this comment.
Our philosophy with Zondax/ Chainport is that we want to keep all 3rd party stuff in the application level and not in the sdk.
There was a problem hiding this comment.
I don't know if I agree with this case, I bet someone is going to ask for this in the sdk. For example, what about oreo wallet? Also this means you have to duplicate code in node app?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
ironfish-cli/package.json
Outdated
| @@ -70,6 +70,8 @@ | |||
| "axios": "1.7.2", | |||
| "bech32": "2.0.0", | |||
| "blessed": "0.1.81", | |||
| "@ledgerhq/hw-transport-node-hid": "6.28.6", | |||
There was a problem hiding this comment.
Can you alphabetize these 2 additions?
Summary
Adds Ledger Utility class. It has 4 main functions:
This utility class will be used by the CLI commands which will be introduced right after this PR.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.