Cleanup sessions on Multisig Broker Server #5480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-if
force-pushed
the
mat/cleanup-broker-sessions
branch
from
36479c0 to
cd90e54
Compare
hughy
approved these changes
Oct 3, 2024
| * session should still be considered active | ||
| */ | ||
| private isSessionActive(sessionId: string): boolean { | ||
| for (const client of this.clients.values()) { |
There was a problem hiding this comment.
Keeping this in mind for a followup task - do you think we should store a list of client IDs on the session? Here and in broadcast we iterate through all of the clients and filter out the ones that aren't in the right session 🫣
There was a problem hiding this comment.
Yeah I think that'd be a good change. I imagine we'll eventually get more and more logic around that, so having it easily accessible will be good.
Comment on lines
115
to
121
| multisigClient.onConnectedMessage.on(() => { | ||
| if (sessionId) { | ||
| Assert.isNotNull(multisigClient) | ||
| multisigClient.joinSession(sessionId) | ||
| multisigClient.onConnectedMessage.clear() | ||
| } | ||
| }) |
There was a problem hiding this comment.
Should we block on waiting for a confirmed connection? If the connected message gets dropped for some reason then we'll continue without ever joining the session. Maybe that's being too paranoid about dropped messages 😅
hughy
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes IFL-3022
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.