optionally retries in cli commands if user rejects Ledger request #5672
Conversation
|
I'm fine with this, but the reason we decided to retry is in case the user accidentally hits deny instead of accept and the pain of starting the process all over from scratch because someone accidentally rejected is a pretty painful UX experience. That being said, if you think this is a better UX I'm ok with it. |
I think a compromise here may be to prompt the user to retry instead of retrying automatically. That protects against accidentally rejecting a request, but avoids unexpected behavior if the user intentionally rejects the request. |
hughy
changed the title
if a user rejects an action on their Ledger, the command will now exit instead of retrying and prompting the user again to approve the action
providers users a way to retry if they rejected by accident because starting over in that case is a very bad experience refactors retry prompt into reusable function
hughy
force-pushed
the
feat/hughy/ledger-reject-exit
branch
from
00c4244 to
eba6449
Compare
Summary
if a user rejects an action on their Ledger, the command will now
exitask the user to retry instead of automatically retrying and prompting the user again to approve the actionTesting Plan
before:
after:
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.