gRPC -> HTTP express #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
commented
Mar 15, 2024
| @@ -0,0 +1,308 @@ | |||
| /* tslint:disable */ | |||
jowparks
commented
Mar 15, 2024
| @@ -0,0 +1,364 @@ | |||
| { | |||
jowparks
commented
Mar 15, 2024
test/cache/leveldb/LOG.old
Outdated
| @@ -0,0 +1,14 @@ | |||
| 2024/03/15-10:34:36.319668 170dff000 Recovering log #68 | |||
| 2024/03/15-10:34:36.320212 170dff000 Level-0 table #70: started | |||
There was a problem hiding this comment.
Added prepopulated test db with 10 records so running cache against server isn't required.
Changes: cleanup add tests add tsoa for openapi generation update example client typing and bug fixes
dguenther
reviewed
Mar 18, 2024
| @@ -51,11 +49,16 @@ | |||
| "ts-node": "10.9.1", | |||
| "ts-proto": "1.155.1", | |||
| "tsc-alias": "^1.8.7", | |||
| "typescript": "5.1.6", | |||
| "vitest": "^0.34.1" | |||
There was a problem hiding this comment.
What was the issue with vitest?
There was a problem hiding this comment.
I remember I ran into an issue when porting these endpoints, unfortunately I forgot what it was 😅 I thought "What is vitest getting for us"? So I just replaced with standard jest since we aren't doing anything special in this repo.
dguenther
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts from
gRPCserver to standardHTTP REST.http://localhost:3000/docssrc/swagger/swagger.json(generated viayarn tsoa-gen)yarn swagger-typescript-api -p ../src/swagger/swagger.json -o src/apistringfor serialized data rather than bytes (as used with protobuf).