Added NetworkInterfaceRef to Machine status
#1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rohit-0505
force-pushed
the
enh/machine_status_nic_claim_ref
branch
3 times, most recently
from
95ad626 to
d22b6d1
Compare
…erface resource Signed-off-by: Rohit Kumar <[email protected]>
…terface resource Signed-off-by: Rohit Kumar <[email protected]>
Rohit-0505
force-pushed
the
enh/machine_status_nic_claim_ref
branch
from
d22b6d1 to
1985c05
Compare
lukasfrank
reviewed
Sep 30, 2024
poollet/machinepoollet/controllers/machine_controller_networkinterface.go
Outdated
Show resolved
Hide resolved
lukasfrank
changed the title
Machine status to track a reference to its claimed NetworkInterface resourceNetworkInterfaceRef to Machine status
|
LGTM |
balpert89
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
NetworkInterfaceRefof typecorev1.LocalObjectReferencetoMachine.Status.NetworkInterfaceStatusstruct for identifying the claimedNetworkInterfaceNetworkInterfaceRefinmachinepoolletFixes #1117