Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flapping IPs in NetworkInterface status #1163

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Fix flapping IPs in NetworkInterface status #1163

merged 3 commits into from
Nov 22, 2024

Conversation

ushabelgur
Copy link
Contributor

Proposed Changes

  • Update NetworkInterface status only when there is change in State or list of IPs

Fixes #1111

@github-actions github-actions bot added size/S bug Something isn't working labels Nov 19, 2024
@ushabelgur ushabelgur marked this pull request as ready for review November 19, 2024 10:03
@ushabelgur ushabelgur requested a review from a team as a code owner November 19, 2024 10:03
@balpert89
Copy link
Contributor

suggestion: the consistently threshold is set to 1 second (see

ironcore/poollet/machinepoollet/controllers/controllers_suite_test.go

Line 57 in 35d01e5

consistentlyDuration = 1 * time.Second
). Please increase this to 5-10 seconds as the flapping could occur after a few seconds.

@ushabelgur ushabelgur self-assigned this Nov 22, 2024
@afritzler afritzler merged commit 9c991b5 into ironcore-dev:main Nov 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@ushabelgur ushabelgur

Labels
bug Something isn't working size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flapping IPs in NetworkInterface status
3 participants
@ushabelgur @balpert89 @afritzler