Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement tolerations for machines and volumes and taints for pools #279

Merged
merged 24 commits into from
Jan 31, 2022
Merged

Implement tolerations for machines and volumes and taints for pools #279

merged 24 commits into from
Jan 31, 2022

Conversation

nikhilbarge
Copy link
Contributor

Proposed Changes

Fixes #278

@github-actions github-actions bot added size/L and removed size/M labels Jan 24, 2022
@nikhilbarge nikhilbarge changed the title WIP: Implement taint tolerations for machine and volume Implement taint tolerations for machine and volume Jan 24, 2022
@nikhilbarge nikhilbarge requested review from adracus and afritzler and removed request for adracus and afritzler January 24, 2022 13:13
adracus
adracus suggested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rework.
Also take a look at Pods + Nodes with taints / tolerations in your local cluster (e.g. kind) to understand the concept of taints / tolerations.

@github-actions github-actions bot removed the size/L label Jan 27, 2022
@LimKianAn LimKianAn requested a review from adracus January 27, 2022 17:17
adracus
adracus reviewed Jan 31, 2022
View reviewed changes
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things, plz fix then we can merge 👍

adracus
adracus reviewed Jan 31, 2022
View reviewed changes
@LimKianAn LimKianAn self-assigned this Jan 31, 2022
@LimKianAn LimKianAn requested a review from adracus January 31, 2022 12:11
@LimKianAn LimKianAn changed the title Implement taint tolerations for machine and volume Implement tolerations for machines and volumes and taints for pools Jan 31, 2022
@adracus adracus merged commit a701614 into main Jan 31, 2022
@adracus adracus deleted the 278_implement_taint_tolerations branch January 31, 2022 13:38
@afritzler afritzler added the enhancement New feature or request label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LimKianAn LimKianAn LimKianAn left review comments

@adracus adracus adracus approved these changes

Assignees

@LimKianAn LimKianAn

Labels
api-change compute enhancement New feature or request size/XL storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Taints / Tolerations for MachinePool / StoragePool
4 participants
@nikhilbarge @adracus @LimKianAn @afritzler