Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config/dev kustomize #95

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Add config/dev kustomize #95

merged 1 commit into from
Jul 31, 2024

Conversation

defo89
Copy link
Contributor

@defo89 defo89 commented Jul 31, 2024

Proposed Changes

config/dev can be used for local dev setup and for now it will disable the kube-rbac-proxy sidecar

@defo89
add dev kustomize
bf3f424 
`config/dev` can be used for local dev setup and for now it will disable the `kube-rbac-proxy` sidecar
@defo89 defo89 requested a review from afritzler July 31, 2024 10:24
@github-actions github-actions bot added enhancement New feature or request size/S labels Jul 31, 2024
@afritzler
Copy link
Member

Should we also remove the Webhook configuration for the dev kustomization?

@defo89
Copy link
Contributor Author

defo89 commented Jul 31, 2024

Should we also remove the Webhook configuration for the dev kustomization?

At least for my tilt case it does not matter since cert-manager is part of the stack.

afritzler
afritzler approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now. We can use a base configuration later to derive default and dev at a later point in time.

@afritzler afritzler merged commit ad21690 into main Jul 31, 2024
8 checks passed
@afritzler afritzler deleted the enh/kustomize-dev branch July 31, 2024 11:40
@defo89 defo89 mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@defo89 @afritzler