Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store ddi or user in recordings #2713

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Store ddi or user in recordings #2713

merged 1 commit into from
Aug 2, 2024

Conversation

danigargar
Copy link
Contributor

@danigargar danigargar commented Aug 1, 2024 •
edited
Loading

Added logic in recordings microservice for setting user or ddi for new records.

Type Of Change

  • Small bug fix
  • New feature or enhancement
  • Breaking change

Checklist:

  • Commits are named and have tag following commit rules
  • Commits are split per component (schema, portal/platform, kamusers, agis, ..)
  • Changes have been tested locally
  • Fixes an existing issue (Fixes #XXXX)
  • Upport from existing Pull request #XXXX

Description

Additional information

@danigargar danigargar added +feature New feature microservices Microservices labels Aug 1, 2024
@danigargar danigargar added this to the 4.2.0 milestone Aug 1, 2024
@danigargar danigargar requested a review from rbatistadev August 1, 2024 10:22
@danigargar danigargar self-assigned this Aug 1, 2024
ironArt3mis
ironArt3mis requested changes Aug 1, 2024
View reviewed changes
Copy link

@ironArt3mis ironArt3mis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review required

@danigargar danigargar force-pushed the PROVIDER-1874-link-ddi-or-user-to-recordings branch from d64fb33 to bf35adb Compare August 1, 2024 10:53
@rbatistadev rbatistadev self-requested a review August 1, 2024 11:11
@danigargar danigargar force-pushed the PROVIDER-1874-link-ddi-or-user-to-recordings branch from bf35adb to 097d163 Compare August 1, 2024 12:55
@cruzccl cruzccl force-pushed the PROVIDER-1874-link-ddi-or-user-to-recordings branch from 097d163 to db18978 Compare August 2, 2024 11:33
@danigargar danigargar merged commit 1b9290c into bleeding Aug 2, 2024
2 checks passed
@danigargar danigargar deleted the PROVIDER-1874-link-ddi-or-user-to-recordings branch August 2, 2024 11:48
@Kaian Kaian added the *tempest* IvozProvider 4.x Tempest Release label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaian Kaian Kaian left review comments

@cruzccl cruzccl cruzccl approved these changes

@ironArt3mis ironArt3mis ironArt3mis approved these changes

@rbatistadev rbatistadev rbatistadev approved these changes

Assignees

@danigargar danigargar

Labels
+feature New feature functional-review microservices Microservices *tempest* IvozProvider 4.x Tempest Release
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@danigargar @cruzccl @Kaian @ironArt3mis @rbatistadev