Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed webPortal logo load #2780

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fixed webPortal logo load #2780

merged 1 commit into from
Oct 1, 2024

Conversation

danigargar
Copy link
Contributor

Fixed webPortal logo load when requested logName contains character not valid in an URL

Type Of Change

  • Small bug fix
  • New feature or enhancement
  • Breaking change

Checklist:

  • Commits are named and have tag following commit rules
  • Commits are split per component (schema, portal/platform, kamusers, agis, ..)
  • Changes have been tested locally
  • Fixes an existing issue (Fixes #XXXX)
  • Upport from existing Pull request #XXXX

Description

Additional information

@danigargar danigargar added +bug Bug core Core Libraries *tempest* IvozProvider 4.x Tempest Release labels Sep 24, 2024
@danigargar danigargar added this to the 4.3.0 milestone Sep 24, 2024
@danigargar danigargar requested a review from R0MANDEV September 24, 2024 14:19
@danigargar danigargar self-assigned this Sep 24, 2024
@danigargar danigargar force-pushed the PROVIDER-2012-fix-webPortal-logo-load branch from c0135d0 to ee7ed83 Compare September 24, 2024 14:26
ironArt3mis
ironArt3mis requested changes Sep 24, 2024
View reviewed changes
Copy link

@ironArt3mis ironArt3mis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review required

@cruzccl cruzccl force-pushed the PROVIDER-2012-fix-webPortal-logo-load branch from ee7ed83 to 907bf9f Compare October 1, 2024 11:07
@danigargar danigargar merged commit 5f5a877 into bleeding Oct 1, 2024
15 checks passed
@danigargar danigargar deleted the PROVIDER-2012-fix-webPortal-logo-load branch October 1, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cruzccl cruzccl cruzccl approved these changes

@ironArt3mis ironArt3mis ironArt3mis approved these changes

@R0MANDEV R0MANDEV R0MANDEV approved these changes

Assignees

@danigargar danigargar

Labels
+bug Bug core Core Libraries functional-review *tempest* IvozProvider 4.x Tempest Release
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@danigargar @cruzccl @ironArt3mis @R0MANDEV