Add Kotlin test missing dependency and fix test dir tree (fix build) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.kotlintestdependency specification was missing in the current master branch. Also, the test code was misplaced. Both these issues prevent a successful build: https://jitpack.io/com/github/italia/cieid-android-sdk/b5a7baef9e/build.logThis pull request adds the missing dependency for
io.kotlintestand move test files to the right path (in SDK library), so both Android Studio andgradletool can distinguish between tests and actual code.Note that I slightly modified imports in both test files to upgrade them to Kotlintest 3.4, as I can't make the 3.2 works.
These fixes also enables this repo to be included directly in Android Studio using https://jitpack.io/ (no need to publish this library in a maven repo)