-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
183 docker compose optimizazione #188
base: master
Are you sure you want to change the base?
Conversation
MdreW
commented
Feb 21, 2025
•
edited
Loading
edited
- use short name for service
- set a prefix for container name
- add build option for iam-proxy service
- add build option in run-docker-compose.sh
- remove not necessary named network
- remove not necessary key like container-name when is identically to service-name
- rename example/plugin to example/configuration
- optimize metadata and key update
- update test to new service name
…container are prefixed with project name), add build options for satosa (you ca use `docker compose up --build` to recompile), removed unecessary named network, removed superfluous key in docker-compose, optimized process for metadata and key update (clean and short)
… `sh`, no executed right requested; commented unused log handled in proxy_conf
… `sh`, no executed right requested; commented unused log handled in proxy_conf
Hi @peppelinux , Spid, eIDAS and CIE backend work fine but if Pyeudi is enable kill the application with this error:
If I change value in row 186 of pyeudy config the error is
For |
services: | ||
|
||
satosa-mongo: | ||
mongo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there might be different containers about mongo, and this is the mongo within the satosa network with a specialized name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The container name is composed by project name +service name + istance number = iam-proxy-italia-mongo-1
The image name is composed by project name +service name = iam-proxy-italia-mongo
But you can call it with the service name in composer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project name is defined in first docker-compose line with key name: iam-proxy-italia
@@ -18,66 +17,50 @@ services: | |||
# - mongodata:/data/db # to be used for external volumes | |||
ports: | |||
- '27017-27019:27017-27019' | |||
networks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per my previous comment
|
||
satosa-mongo-express: | ||
express: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per my previous comment
|
||
django_sp: | ||
sp: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a django sp, therefore its name is django sp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we haven't other SP, why distinguish them?
But if you prefer we can call this django-sp 😄
Remember: the container name will be iam-proxy-italia-django-sp-1
With a long project name a short service is useful
|
||
iam-proxy-italia: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iam-proxy-italia is the container name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iam-proxy-italia is the project name. Whe should call the service with a functional name for his work.
If you wont call it as satosa
for don't make confusion we can call it iam-proxy
? but the full container name will be iam-proxy-italia-iam-proxy-1
... a really uncomfortable name, you don't think?
# spid_daily: | ||
# class: logging.handlers.TimedRotatingFileHandler | ||
# level: INFO | ||
# formatter: simple | ||
# filename: logs/spid.log | ||
# when: D | ||
# interval: 1 | ||
# backupCount: 860 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
let's keep cie and spid policy retention configured by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In docker spid daily is not used, the log are sended to docker logs from STDOUT. Spid daily handler is used only for local installation and must be configured manually in proxy_conf.yaml.
If remain uncommented the image require an un-necessary write access right to logs/spid.log
empty file.
If someone want use this must uncommented this and change the handler loggers from [console]
to [spid_daily]
. If you want to use spid-daily you still need to edit the proxy-conf file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GET_METADATA_AND_KEY=true is good
other breakign changes will not be supported, liek the rename of the containrs that was something early made for design purpose