Add histogram support for acquire duration #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sashayakovtseva <[email protected]>
Signed-off-by: sashayakovtseva <[email protected]>
Signed-off-by: sashayakovtseva <[email protected]>
|
Sorry, I don't think this would be a good fit for puddle. puddle avoids external dependencies and this brings in the github.com/prometheus/client_golang. If there was a non-invasive approach to allowing instrumentation or external metrics, I would consider it. But the primary goal for puddle is stability and the bar is really high for changes. See https://github.com/jackc/puddle#status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I think it might be useful to have an acquire duration histogram, so I added one :)
Histogram is optional, one can enable it with options. Approach is inspired by prom grpc middleware.
Let me know if any changes are needed for this PR to be accepted, I am open for discussion.
Also please let me know if there's no intend to add such histogram support at all.