Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 605 #608

Merged
merged 3 commits into from
Mar 11, 2023
Merged

Issue 605 #608

merged 3 commits into from
Mar 11, 2023

Conversation

jackdewinter
Copy link
Owner

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 11, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 4.48%.

Quality metrics Before After Change
Complexity 4.69 ⭐ 4.26 ⭐ -0.43 👍
Method Length 89.75 🙂 73.25 🙂 -16.50 👍
Working memory 10.55 😞 9.21 🙂 -1.34 👍
Quality 60.97% 🙂 65.45% 🙂 4.48% 👍
Other metrics Before After Change
Lines 6415 3670 -2745
Changed files Quality Before Quality After Quality Change
pymarkdown/tokenized_markdown.py 63.00% 🙂 63.00% 🙂 0.00%
pymarkdown/container_blocks/container_block_nested_processor.py 53.52% 🙂 53.52% 🙂 0.00%
pymarkdown/container_blocks/container_block_non_leaf_processor.py 55.72% 🙂 55.72% 🙂 0.00%
pymarkdown/container_blocks/container_block_processor.py 65.50% 🙂 65.49% 🙂 -0.01% 👎
pymarkdown/container_blocks/container_grab_bag.py 85.64% ⭐ 85.64% ⭐ 0.00%
pymarkdown/extensions/pragma_token.py 63.82% 🙂 63.82% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pymarkdown/container_blocks/container_block_non_leaf_processor.py ContainerBlockNonLeafProcessor.__look_for_override 9 🙂 191 😞 16 ⛔ 41.33% 😞 Try splitting into smaller methods. Extract out complex expressions
pymarkdown/tokenized_markdown.py TokenizedMarkdown.__handle_blank_line 10 🙂 207 ⛔ 14 😞 41.57% 😞 Try splitting into smaller methods. Extract out complex expressions
pymarkdown/tokenized_markdown.py TokenizedMarkdown.__handle_blank_line_token_stack 8 ⭐ 194 😞 16 ⛔ 42.02% 😞 Try splitting into smaller methods. Extract out complex expressions
pymarkdown/container_blocks/container_block_non_leaf_processor.py ContainerBlockNonLeafProcessor.__handle_leading_whitespace_loop 16 🙂 170 😞 12 😞 42.43% 😞 Try splitting into smaller methods. Extract out complex expressions
pymarkdown/container_blocks/container_block_non_leaf_processor.py ContainerBlockNonLeafProcessor.__handle_leading_whitespace 12 🙂 176 😞 13 😞 43.68% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@jackdewinter jackdewinter merged commit c731696 into main Mar 11, 2023
@jackdewinter jackdewinter deleted the issue-605 branch March 11, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant