Forced, preferred, or optimal searcher selection #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses order as before but has well-defined places to fill in handling of dumb-jump-force-searcher and dumb-jump-prefer-searcher.
A few tests had previously used an incorrect set of regexes due to how it detected which searcher was in use. Now it's explicitly given to (dumb-jump-get-contextual-regexes) what search is used/requested.
1 similar comment
|
Awesome! Almost 100% coverage now, @jacktasia. |
|
This is great! Thanks! |
jobor
pushed a commit
to jobor/dumb-jump
that referenced
this pull request
Feb 18, 2025
* New structure for picking grep variants Uses order as before but has well-defined places to fill in handling of dumb-jump-force-searcher and dumb-jump-prefer-searcher. * Respecting dumb-jump-force-searcher and dumb-jump-prefer-searcher * Use git-grep in git repos when no searcher is forced * Only use git-grep in git repos when installed * Fix tests to comply with changes A few tests had previously used an incorrect set of regexes due to how it detected which searcher was in use. Now it's explicitly given to (dumb-jump-get-contextual-regexes) what search is used/requested. * Tests to improve code coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #109, two new variables have been created:
dumb-jump-prefer-searcherdumb-jump-force-searcherBoth default to
nil.dumb-jump-prefer-searchercan use'ag,'rg,'git-grep,'gnu-grep, or'grep. Ifnilthen the most optimal searcher will be chosen at runtime.dumb-jump-force-searcherforces to use searcher'ag,'rg,'git-grep,'gnu-grep, or'grep. Set tonilto not force anything and usedumb-jump-prefer-searcheror most optimal searcher.In addition, if no searcher is forced, project root has a
.git, andgit-grepis installed then it will use that instead. Otherwise, it uses the fastest searcher that is installed in the following order:ag,rg,gnu-grep, orgrep.