Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow excluding type annotation checks #352

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

dstepanov
Copy link
Contributor

There is a bug in the annotation processor not providing type annotations for classes loaded from the classpath.
https://bugs.openjdk.java.net/browse/JDK-8225377

Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I'd probably call the field RUN_TYPE_ANNOTATION_TESTS (defaulting to true) so that the if statements don't have to negate the condition. But that's just nitpicking.

@dstepanov
Copy link
Contributor Author

I did rename the property. Not sure why the build is failing.
It would be nice to have it released so we can integrate it into the test suite.

@Ladicek
Copy link
Contributor

Ladicek commented Mar 21, 2022

The build fails most likely because of this commit: b557cc9 That was introduced in preparation of the final CDI 4.0 release I think. Let me check locally.

@Ladicek
Copy link
Contributor

Ladicek commented Mar 21, 2022

I rebased this PR locally on the 4.0.0.RC6 tag and mvn clean verify passes just fine. So the build failures are just an artifact of preparation for staging the final build. That is, this PR may go in, in my opinion.

I don't know what's the process right now, but I believe we're retracting the 4.0.0 release due to a TCK deficiency anyway (see #353), so we should be able to get this in for the 4.0.0 release too. CC @starksm64

@graemerocher graemerocher merged commit 6022e37 into jakartaee:master Mar 22, 2022
@dstepanov dstepanov deleted the lan branch March 23, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants