Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player Names with Special Characters #4

Merged
merged 2 commits into from
Jan 3, 2020
Merged

Player Names with Special Characters #4

merged 2 commits into from
Jan 3, 2020

Conversation

Rossiar
Copy link
Collaborator

@Rossiar Rossiar commented Jan 2, 2020

It'd be great if you could create a release after this update - then I can delete our fork and use your module as is - right now because you don't have a release I have to use the following in my go.mod:

require (
	github.com/janstuemmel/csgo-log v1.0.0
)

replace github.com/janstuemmel/csgo-log => github.com/faceit/csgo-log v1.1.1

@janstuemmel
Copy link
Owner

ok i will review and bump to 2.0.1 then

@janstuemmel
Copy link
Owner

.travis.yml should be updated to go version 1.3 as well

@Rossiar
Copy link
Collaborator Author

Rossiar commented Jan 3, 2020

I updated it and force-pushed, the build passed so lgtm

@janstuemmel janstuemmel merged commit 8d01c6f into janstuemmel:master Jan 3, 2020
@janstuemmel
Copy link
Owner

merged and tagged to version v2.0.1. Tanks for all the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rossiar @janstuemmel